Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value_counts operation is too slow, nearly stuck #763

Closed
universewill opened this issue Aug 22, 2019 · 2 comments
Closed

value_counts operation is too slow, nearly stuck #763

universewill opened this issue Aug 22, 2019 · 2 comments
Labels
Help Wanted 🌐 Issues good for external contributors. new feature/request 💬 Requests and pull requests for new features

Comments

@universewill
Copy link

i found that the 'value_count' operation will stuck:

UserWarning: `Series.value_counts` defaulting to pandas implementation.
To request implementation, send an email to feature_requests@modin.org.
UserWarning: Distributing <class 'pandas.core.series.Series'> object. This may take some time.

It seems that modin tries to convert modin df to pandas df, and it is very slow.

@universewill universewill changed the title value_counts operation is too slow value_counts operation is too slow, nearly stuck Aug 22, 2019
@devin-petersohn
Copy link
Collaborator

Hi @universewill, thanks for posting.

This is not yet implemented in a distributed way, I will tag as Feature Request and Help Wanted. Let me know if you'd like to contribute!

@devin-petersohn devin-petersohn added Help Wanted 🌐 Issues good for external contributors. new feature/request 💬 Requests and pull requests for new features labels Aug 22, 2019
@anmyachev
Copy link
Collaborator

Distributed value_counts was be implemented in #1535. Now this operation should be faster.

@universewill feel free to reopen this issue if there will be performance issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted 🌐 Issues good for external contributors. new feature/request 💬 Requests and pull requests for new features
Projects
None yet
Development

No branches or pull requests

3 participants