Parity fixes #1078
Closed
Parity fixes #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @elonp! Since you're a return contributor, would it be possible to split this patch up into the individual components being fixed? Ideally, we would like to have one PR for one fix, that way if we need to roll back we don't have to undo a bunch of unrelated changes. If you'd like for me to help with this, I'm happy to, just let me know! |
|
Sure.
But I'm travelling with limited connectivity until the 23rd. I might find
time to do it before, but feel free to go ahead and do it yourself if you'd
like.
Thanks!
Elon
…On Fri, 14 Feb 2020, 04:19 Devin Petersohn, ***@***.***> wrote:
Thanks @elonp <https://github.com/elonp>!
Since you're a return contributor, would it be possible to split this
patch up into the individual components being fixed? Ideally, we would like
to have one PR for one fix, that way if we need to roll back we don't have
to undo a bunch of unrelated changes.
If you'd like for me to help with this, I'm happy to, just let me know!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1078?email_source=notifications&email_token=ACKVMEVVIKJLQ5IDDTJX6FTRCYLWXA5CNFSM4KU6S272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELXQSLQ#issuecomment-586090798>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKVMEWW5JPROECVAXDC2YLRCYLWXANCNFSM4KU6S27Q>
.
|
This was referenced Feb 18, 2020
|
Great. Thank you.
…On Tue, Feb 18, 2020 at 6:08 PM Devin Petersohn ***@***.***> wrote:
@elonp <https://github.com/elonp> I cherry-picked the commits from this
PR into 3 separate PRs and created 3 issues in the issue tracker to
track/label the fixes.
#1084 <#1084>, #1086
<#1086>, and #1088
<#1088> are the new PRs
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1078?email_source=notifications&email_token=ACKVMEQO3BZ2QUFXRW7NA4TRDQPZLA5CNFSM4KU6S272YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMDAMAA#issuecomment-587597312>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKVMEQ7SNYXOJTCAPODXJDRDQPZLANCNFSM4KU6S27Q>
.
|
|
Closing as this work was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few parity fixes in series and dataframes:
__radd__that allows 10+s where s is a Series)Series.__getitem__.df.loc[row_key]whererow_keywas used as a column key if it happened to match columnsRelated issue number
None that I could find
flake8 modinblack --check modin