-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#1911: support cat methods #1912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1912 +/- ##
==========================================
+ Coverage 81.53% 81.67% +0.14%
==========================================
Files 79 79
Lines 9192 9274 +82
==========================================
+ Hits 7495 7575 +80
- Misses 1697 1699 +2
Continue to review full report at Codecov.
|
YarShev
reviewed
Aug 18, 2020
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
@ienkovich , thanks, LGTM! |
YarShev
approved these changes
Aug 19, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ienkovich ilya.enkovich@intel.com
What do these changes do?
Support cat.* methods. We are still defaulting to pandas but modifying operations work with this patch. cat.codes implementation is moved to backend because we have it implemented for OmniSci backend.
flake8 modin
black --check modin
git commit -s