FEAT-#1838: Lazy map evaluation at Pandas backend #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchigarev
force-pushed
the
issue-1838
branch
2 times, most recently
from
fc314af
to
5e62ad9
Compare
|
Codecov Report
@@ Coverage Diff @@
## master #1940 +/- ##
==========================================
+ Coverage 76.63% 81.76% +5.13%
==========================================
Files 79 79
Lines 9303 9303
==========================================
+ Hits 7129 7607 +478
+ Misses 2174 1696 -478
Continue to review full report at Codecov.
|
dchigarev
changed the title
|
|
dchigarev
requested review from
YarShev and
devin-petersohn
and removed request for
YarShev
YarShev
requested changes
Aug 24, 2020
There was a problem hiding this comment.
Why did you replace part.apply/obj.apply to part.add_to_apply_calls/obj.add_to_apply_calls in broadcast_apply, _apply_func_to_list_of_partitions and _apply_func_to_list_of_partitions_broadcast only. We have many places where part.apply/obj.apply is used. Can we replace this somewhere else?
there are a few places where we still have
|
|
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
Signed-off-by: Dmitry Chigarev <dmitry.chigarev@intel.com>
|
@YarShev replacing Call queue is the partitions abstraction, and it must be explicitly drained with a special partition method before every serialization. So if we'll do So, there are two different solutions:
new_idx = [part.add_to_apply_calls(fn) for part in partitions]
new_idx = [part.drain_call_queue() for part in partitions]
new_idx = [part.oid for part in partitions]
return ray.get(new_idx)Which is looks kinda strange, and do not have any real advantages before just doing |
@dchigarev , okay, I see. Let's keep |
YarShev
approved these changes
Aug 28, 2020
aregm
pushed a commit
to aregm/modin
that referenced
this pull request
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modinblack --check modingit commit -sMapFunctionis very slow at Ray engine #1838