-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#2009: avoid index access in is_scalar calls #2010
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
==========================================
+ Coverage 81.79% 81.84% +0.05%
==========================================
Files 79 79
Lines 9403 9457 +54
==========================================
+ Hits 7691 7740 +49
- Misses 1712 1717 +5
Continue to review full report at Codecov.
|
Signed-off-by: ienkovich <ilya.enkovich@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ienkovich , thanks, LGTM!
…odin-project#2010) Signed-off-by: ienkovich <ilya.enkovich@intel.com>
What do these changes do?
Wrap pandas.is_scalar method to handle
BasePandasDataset
objects separately. The problem is that callingpandas.is_scalar
forBasePandasDataset
object triggers execution for lazy frames.flake8 modin
black --check modin
git commit -s