FEAT-#2013: Improved merge_asof implementation #2178
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oach. Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Codecov Report
@@ Coverage Diff @@
## master #2178 +/- ##
===========================================
- Coverage 83.99% 64.67% -19.32%
===========================================
Files 119 113 -6
Lines 13063 12844 -219
===========================================
- Hits 10972 8307 -2665
- Misses 2091 4537 +2446
Continue to review full report at Codecov.
|
|
|
|
|
@devin-petersohn ping—if you have a chance, would love some feedback on this sketch before proceeding. |
There was a problem hiding this comment.
Sorry for the delay in response, I took some vacation to rest. I'm still getting caught up.
The implementation here, while not super efficient, will be better than the current default behavior. We should still probably throw the warning for defaulting to pandas because we are collecting whole column(s) to the driver to compute the merge.
Otherwise it looks good until we can have a better internal way of joins with conditionals.
…r' into merge_asof/2013 Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
1. Move test to correct location. 2. Test with more interesting indexes. 3. Start setting up infrastructure for testing different on variations. Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
Will re-open when it's ready for review. |
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
@devin-petersohn probably still needs testing of some of the fallback edge cases, but this is a lot closer to done, and so could use another passthrough. So many edge cases... and I feel like I'm handling them in super-hacky ways. |
itamarst
changed the title
|
@devin-petersohn any thoughts? |
|
Looks like:
|
…in Pandas. Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
@devin-petersohn I guess this is ready for review now? Main caveat I have is that example dataframes for tests were taken from Pandas docs, so potentially licensing issue that would need to fixed, not sure whether that's a problem or not. |
itamarst
changed the title
devin-petersohn
requested changes
Nov 25, 2020
Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org> Co-authored-by: Devin Petersohn <devin-petersohn@users.noreply.github.com>
itamarst
force-pushed
the
merge_asof/2013
branch
from
af2cffd
to
69c1031
Compare
|
I can fix the commit by squash merging, my attempts at rebases have failed due to limits of my Git knowledge. So I can do that, or if you know you can do that. Perhaps the 70 character limit could be removed? It doesn't seem lack it adds much... 😁 |
|
Part of the 70 limit is a github thing, messages longer than that are chopped. I increased it to 88 in #2489. |
…r' into merge_asof/2013 Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
OK, merged forward, hopefully everything will pass (once GitHub Actions gets unbroken for the day, I guess? Seems like they're having issues). |
…r' into merge_asof/2013 Signed-off-by: Itamar Turner-Trauring <itamar@itamarst.org>
|
@devin-petersohn another frustrating git commit lint failure. I'm going to just turn this into a patch, and create a completely new PR with a new branch :( |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This is a sketch of an approach to
merge_asofthat is more efficient than the current approach, hopefully.@devin-petersohn would appreciate some feedback on e.g. which bits are potentially inefficient.
flake8 modinblack --check modingit commit -s