FIX-#3818: Ignore files from /private/tmp/ray/ when detecting file leaks #3826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffreykennethli
force-pushed
the
ignore_ray_logs
branch
2 times, most recently
from
be1d337 to
9166dd3
Compare
…cting file leaks Signed-off-by: jeffreykennethli <jkli@ponder.io>
jeffreykennethli
force-pushed
the
ignore_ray_logs
branch
from
9166dd3 to
4a54856
Compare
Signed-off-by: jeffreykennethli <jkli@ponder.io>
|
Codecov Report
@@ Coverage Diff @@
## master #3826 +/- ##
===========================================
- Coverage 85.38% 56.40% -28.98%
===========================================
Files 197 183 -14
Lines 16437 15755 -682
===========================================
- Hits 14035 8887 -5148
- Misses 2402 6868 +4466
Continue to review full report at Codecov.
|
|
|
Signed-off-by: jeffreykennethli <jkli@ponder.io>
The logs structure is /tmp/ray/session_*/logs per the docs: https://docs.ray.io/en/master/ray-logging.html#logging-directory-structure Modified the check to more explicitly check for this format. |
dorisjlee
pushed a commit
to dorisjlee/modin
that referenced
this pull request
Jan 13, 2022
…cting file leaks (modin-project#3826) Signed-off-by: jeffreykennethli <jkli@ponder.io> Signed-off-by: Doris Lee <dorisjunglinlee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jeffreykennethli jkli@ponder.io
What do these changes do?
test_io.p::TestExcel open file handle checks currently catches our check_file_leaks decorator check due to Ray session driver logs that are still open after read_excel(). check_file_leaks compares open files before and after a test case, therefore only the first instance where a Ray session is initiated will catch check_file_leaks.
The session logs still being open is the intended Ray behavior, so our tests should ignore these open files in check_file_leaks. This change adds this exception to check_file_leaks.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date