DOCS-#3936: Update copyright year #3937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YarShev
changed the title
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
YarShev
force-pushed
the
dev/yigoshev-issue3936
branch
from
aa2c5e6
to
4ff1113
Compare
Codecov Report
@@ Coverage Diff @@
## master #3937 +/- ##
===========================================
- Coverage 85.53% 36.00% -49.54%
===========================================
Files 198 185 -13
Lines 16540 15860 -680
===========================================
- Hits 14148 5710 -8438
- Misses 2392 10150 +7758
Continue to review full report at Codecov.
|
|
|
|
| @@ -48,7 +48,7 @@ def noop_decorator(*args, **kwargs): | |||
| export_config_help(configs_file_path) | |||
|
|
|||
| project = "Modin" | |||
| copyright = "2018-2021, Modin" | |||
| copyright = "2018-2022, Modin" | |||
There was a problem hiding this comment.
is there any reason this is "Modin" and not "Modin Developers" or vice versa?
There was a problem hiding this comment.
This copyright is shown in our documentation. "Modin Developers" would look strange to me.
There was a problem hiding this comment.
I think it is weird that we have Modin Developers in the NOTICE file, but not here, we can change it in a new PR.
@jeffreykennethli do you want to open a new issue for it?
devin-petersohn
approved these changes
Jan 13, 2022
| @@ -48,7 +48,7 @@ def noop_decorator(*args, **kwargs): | |||
| export_config_help(configs_file_path) | |||
|
|
|||
| project = "Modin" | |||
| copyright = "2018-2021, Modin" | |||
| copyright = "2018-2022, Modin" | |||
There was a problem hiding this comment.
I think it is weird that we have Modin Developers in the NOTICE file, but not here, we can change it in a new PR.
@jeffreykennethli do you want to open a new issue for it?
7 tasks
mvashishtha
pushed a commit
to devin-petersohn/modin
that referenced
this pull request
Jan 19, 2022
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igoshev, Yaroslav yaroslav.igoshev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date