FIX-#3962: Change docs copyright statement to 'Modin Developers.' #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elopers.' Signed-off-by: jeffreykennethli <jkli@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #3964 +/- ##
===========================================
- Coverage 80.01% 47.19% -32.82%
===========================================
Files 199 185 -14
Lines 16531 15841 -690
===========================================
- Hits 13227 7476 -5751
- Misses 3304 8365 +5061
Continue to review full report at Codecov.
|
|
|
|
YarShev
reviewed
Jan 14, 2022
| @@ -48,7 +48,7 @@ def noop_decorator(*args, **kwargs): | |||
| export_config_help(configs_file_path) | |||
|
|
|||
| project = "Modin" | |||
| copyright = "2018-2022, Modin" | |||
| copyright = "2018-2022, Modin Developers." | |||
There was a problem hiding this comment.
I think it was supposed to change Modin Developers to Modin in the NOTICE file as part of our discussion in #3937, but not Modin to Modin Developers here. cc @devin-petersohn
There was a problem hiding this comment.
The copyright belongs to Modin devleopers, not Modin, so I think it is correct to be Modin Developers. Maybe my understanding is wrong.
YarShev
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jeffreykennethli jkli@ponder.io
What do these changes do?
Change the docs copyright statement to match the statement in our NOTICE file.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date