-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT-#4035: Upgrade pandas support to 1.4 #4036
Conversation
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4036 +/- ##
===========================================
- Coverage 79.59% 57.80% -21.79%
===========================================
Files 201 187 -14
Lines 16738 15911 -827
===========================================
- Hits 13323 9198 -4125
- Misses 3415 6713 +3298
Continue to review full report at Codecov.
|
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
@prutskov, take a look at |
@devin-petersohn, let's move step-by-step by fixing single tests. Could you take a look at these?
|
Details are in pandas-dev/pandas#44944
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
…ax_{rows|cols} in call to pandas.get_option Signed-off-by: Rehan Durrani <rehan@ponder.io>
…into issues/4035 Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Rehan Durrani <rehan@ponder.io>
…to skipna Signed-off-by: Rehan Durrani <rehan@ponder.io>
Signed-off-by: Igoshev, Yaroslav <yaroslav.igoshev@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks to everyone involved.
modin/experimental/core/execution/native/implementations/omnisci_on_native/io/io.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Vasily Litvinov <vasilij.n.litvinov@intel.com>
d9e983d
modin/experimental/core/execution/native/implementations/omnisci_on_native/io/io.py
Show resolved
Hide resolved
…ci_on_native/io/io.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments - once addressed, LGTM!
modin/experimental/core/execution/native/implementations/omnisci_on_native/io/io.py
Show resolved
Hide resolved
.../experimental/core/execution/native/implementations/omnisci_on_native/test/test_dataframe.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Rehan Durrani <rehan@ponder.io>
62f2946
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Devin Petersohn devin.petersohn@gmail.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date