Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#4229: remove unused dask_client global variable in modin\pandas\__init__.py #4230

Merged
merged 1 commit into from
Feb 19, 2022
Merged

REFACTOR-#4229: remove unused dask_client global variable in modin\pandas\__init__.py #4230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release_notes/release_notes-0.14.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ Key Features and Updates
*
* Refactor Codebase
* REFACTOR-#3990: remove code duplication in `PandasDataframePartition` hierarchy (#3991)
* REFACTOR-#4229: remove unused `dask_client` global variable in `modin\pandas\__init__.py` (#4230)
* REFACTOR-#3997: remove code duplication for `broadcast_apply` method (#3996)
* REFACTOR-#4213: Refactor `modin/examples/tutorial/` directory (#4214)
* REFACTOR-#4206: add assert check into `__init__` method of `PandasOnDaskDataframePartition` class (#4207)
Expand Down
2 changes: 0 additions & 2 deletions modin/pandas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,12 @@
os.environ["OMP_NUM_THREADS"] = "1"

_is_first_update = {}
dask_client = None
_NOINIT_ENGINES = {
"Python",
} # engines that don't require initialization, useful for unit tests


def _update_engine(publisher: Parameter):
global dask_client
from modin.config import StorageFormat, CpuCount
from modin.config.envvars import IsExperimental
from modin.config.pubsub import ValueSource
Expand Down
1 change: 0 additions & 1 deletion modin/pandas/test/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ def test_top_level_api_equality():
"os",
"multiprocessing",
"Client",
"dask_client",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmyachev, could you check this list for other options to be removed? I think we can delete something else.

"get_client",
]

Expand Down