-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-#4272: Add bar chart comparisons to quick start guide #4277
Conversation
Signed-off-by: Doris Lee <dorisjunglinlee@gmail.com>
Signed-off-by: Doris Lee <dorisjunglinlee@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #4277 +/- ##
===========================================
- Coverage 86.99% 62.90% -24.09%
===========================================
Files 207 207
Lines 17063 17063
===========================================
- Hits 14844 10734 -4110
- Misses 2219 6329 +4110
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@@ -165,6 +165,11 @@ across a single column via the ``apply`` operation. | |||
Modin is more than 30X faster at applying a single column of data, operating on 130+ | |||
million rows in a second. | |||
|
|||
In short, Modin provides orders of magnitude speed up over pandas for a variety of operations out of the box. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code used to generate the speedups can be found in examples/jupyter
at the top-level Modin directory. Would point a link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notebook for the quickstart is slightly different from examples/jupyter
and should be this one. We've linked this on the top of the page for people to follow along.
Signed-off-by: Doris Lee <dorisjunglinlee@gmail.com>
In the picture it is written |
Made the change to the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorisjlee, LGTM, thanks!
Signed-off-by: Doris Lee dorisjunglinlee@gmail.com
What do these changes do?
Added bar chart comparisons to quick start guide.
See preview: https://modin--4277.org.readthedocs.build/en/4277/getting_started/quickstart.html
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date