REFACTOR-#4510: Align experimental and regular IO modules initializations #4511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4511 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 228 228
Lines 18413 18413
=======================================
Hits 15902 15902
Misses 2511 2511 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
alexander3774
force-pushed
the
align_exp_io
branch
from
46446eb
to
c84e3ac
Compare
|
alexander3774
force-pushed
the
align_exp_io
branch
2 times, most recently
from
8f74f52
to
074e186
Compare
RehanSD
reviewed
Jun 1, 2022
| assert IsExperimental.get(), "This only works in experimental mode" | ||
| _, _, _, kwargs = inspect.getargvalues(inspect.currentframe()) | ||
|
|
There was a problem hiding this comment.
Is there a reason why the kwargs line was moved up?
There was a problem hiding this comment.
Yes, kwargs line was moved up to avoid passing FactoryDispatcher argument into kwargs. If FactoryDispatcher argument is present in the kwargs, it can break further io logic.
alexander3774
force-pushed
the
align_exp_io
branch
2 times, most recently
from
26ccc9a
to
71ae6a5
Compare
Thanks for review! Unfortunetely CI failed because of CI-related issues, hope it restores soon. |
|
@alexander3774, LGTM, thanks for the changes. |
Signed-off-by: alexander3774 <myskova977@gmail.com>
Signed-off-by: alexander3774 <myskova977@gmail.com>
Signed-off-by: alexander3774 <myskova977@gmail.com>
alexander3774
force-pushed
the
align_exp_io
branch
from
71ae6a5
to
d544d98
Compare
YarShev
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: alexander3774 myskova977@gmail.com
What do these changes do?
Refactoring
modin.experimental.pandas.ioto be in line with changes introduced in #4017.Closes #4510.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date