Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT-#7156: Add type hints for Series #7154

Merged
merged 1 commit into from
Apr 9, 2024
Merged

FEAT-#7156: Add type hints for Series #7154

merged 1 commit into from
Apr 9, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 5, 2024 •
edited
Loading

What do these changes do?

Here type hints are added mainly for return values from functions. If the function returns Series, then it will be possible to use auto completion (a list of available functions and attributes is visible), which currently does not work at all.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Add type hints for Series functions #7156
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 5, 2024
View reviewed changes
modin/pandas/series.py
Comment on lines +2474 to +2484
def _create_or_update_from_compiler(
self, new_query_compiler, inplace=False
) -> Union[Series, None]:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
@anmyachev anmyachev changed the title FEAT-#0000: Add type hints for Series FEAT-#7156: Add type hints for Series Apr 8, 2024
@anmyachev anmyachev marked this pull request as ready for review April 8, 2024 19:37
@anmyachev anmyachev force-pushed the series-type-hints branch 2 times, most recently from 093bd2d to 1f6e03c Compare April 9, 2024 11:21
@YarShev YarShev merged commit 4ad1807 into modin-project:master Apr 9, 2024
36 checks passed
@YarShev
Copy link
Collaborator

YarShev commented Apr 9, 2024

The commit message was not signed off but I added it manually this time.

@anmyachev anmyachev deleted the series-type-hints branch April 10, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

@devin-petersohn devin-petersohn Awaiting requested review from devin-petersohn devin-petersohn is a code owner

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type hints for Series functions
2 participants
@anmyachev @YarShev