FIX-#7157: Make sure quantile function works with numeric_only=True
#7160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmyachev
commented
Apr 9, 2024
| return self.__constructor__( | ||
| query_compiler=self._query_compiler.quantile_for_list_of_values( | ||
| axis = numeric_only_df._get_axis_number(axis) | ||
| if isinstance(q, (pandas.Series, np.ndarray, pandas.Index, list, tuple)): |
There was a problem hiding this comment.
One of the problems was that in the case of a tuple, the quantile_for_list_of_values implementation must be used (instead of quantile_for_single_value).
anmyachev
commented
Apr 9, 2024
anmyachev
commented
Apr 9, 2024
Comment on lines
+2326
to
+2330
| numeric_only_df = self.drop( | ||
| columns=[ | ||
| i for i in self.dtypes.index if not is_numeric_dtype(self.dtypes[i]) | ||
| ] | ||
| ) |
There was a problem hiding this comment.
This is the second problem, due to the fact that we did not drop non numeric columns, internal and external index did not match.
numeric_only=True case has not been tested before.
anmyachev
requested review from
devin-petersohn,
mvashishtha,
RehanSD,
YarShev,
vnlitvinov,
dchigarev and
a team
as code owners
YarShev
reviewed
Apr 9, 2024
YarShev
approved these changes
Apr 10, 2024
…eric_only=True' Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Co-authored-by: Iaroslav Igoshev <Poolliver868@mail.ru>
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date