Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#7292: Prepare Modin code for NumPy 2.0 #7293

Merged
merged 1 commit into from
May 29, 2024
Merged

FIX-#7292: Prepare Modin code for NumPy 2.0 #7293

merged 1 commit into from
May 29, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 29, 2024 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Prepare Modin code to NumPy 2.0 #7292
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-modin-project#7292: Prepare Modin code to NumPy 2.0
7a49d2a 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review May 29, 2024 10:17
@anmyachev anmyachev changed the title FIX-#7292: Prepare Modin code to NumPy 2.0 FIX-#7292: Prepare Modin code for NumPy 2.0 May 29, 2024
devin-petersohn
devin-petersohn approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmyachev anmyachev merged commit 2006292 into modin-project:main May 29, 2024
37 checks passed
@anmyachev anmyachev deleted the issue7292 branch May 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devin-petersohn devin-petersohn devin-petersohn approved these changes

@mvashishtha mvashishtha Awaiting requested review from mvashishtha mvashishtha is a code owner

@RehanSD RehanSD Awaiting requested review from RehanSD RehanSD is a code owner

@YarShev YarShev Awaiting requested review from YarShev YarShev is a code owner

@vnlitvinov vnlitvinov Awaiting requested review from vnlitvinov vnlitvinov is a code owner

@dchigarev dchigarev Awaiting requested review from dchigarev dchigarev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare Modin code to NumPy 2.0
2 participants
@anmyachev @devin-petersohn