Create SeriesGroupBy wrapper to default to pandas and return to Modin #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Resolves modin-project#878 * Create a `SeriesGroupBy` object that intercepts every call to the `SeriesGroupBy` object, applies it to the pandas object, then re-distributes the object if it is a `pandas.Series` or a `pandas.DataFrame`. This is a temporary measure until we can implement a `SeriesGroupBy` object with all of the methods. * This issue originally surfaced with issues handling interactions between pandas and modin Series objects. * A further pass is required to remove other cases where Modin can return a pandas object.
Codecov Report
@@ Coverage Diff @@
## master #908 +/- ##
==========================================
+ Coverage 87.72% 87.74% +0.01%
==========================================
Files 54 54
Lines 5742 5743 +1
==========================================
+ Hits 5037 5039 +2
+ Misses 705 704 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeriesGroupByobject that intercepts every call to theSeriesGroupByobject, applies it to the pandas object, thenre-distributes the object if it is a
pandas.Seriesor apandas.DataFrame. This is a temporary measure until we can implementa
SeriesGroupByobject with all of the methods.between pandas and modin Series objects.
return a pandas object.
What do these changes do?
Related issue number
flake8 modinblack --check modin