Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login Button of screen #957

Closed
Nachtwind1 opened this issue Dec 26, 2023 · 7 comments
Closed

Login Button of screen #957

Nachtwind1 opened this issue Dec 26, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@Nachtwind1
Copy link

Nachtwind1 commented Dec 26, 2023 •
edited
Loading

Describe the bug

The Login Button after you start the app for the first time is offscreen
image

Steps to reproduce

  1. idk if it has something to do with that, scale your screen smaller using NVIDIA Control Panel.
  2. open the Modrinth app with no savedata of the app (so delete: C:\Users\ \AppData\com.modrinth.theseus)
  3. Press the Getting started button
  4. wait for the image to load
  5. Suffer because you need to use curseforge

System information

Windows 10, Nvidia Geforce Rtx 3050, AMD Ryzen 5 and 16 Gb of ram
@Nachtwind1 Nachtwind1 added the bug Something isn't working label Dec 26, 2023
@triphora
Copy link
Contributor

You just need to increase the size of the window.

@triphora triphora closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2024
@Nachtwind1
Copy link
Author

Nachtwind1 commented Jan 27, 2024 via email

@triphora
Copy link
Contributor

What is your screen resolution?

@Nachtwind1
Copy link
Author

Nachtwind1 commented Jan 27, 2024 via email

@w26ad
Copy link

w26ad commented Jan 27, 2024

Even on 1366x768 screen you can see the button at 100% scale:
oQTJAqL

I've heard about problems with 1280x720 screens, but 1600x900 should be normal
Maybe you have more than 100% scale set in your system settings?

@io-tronic
Copy link

I would suggest you reconsider @triphora. My blind friend is unable to use this launcher as a result of this issue. Accommodating a range of text sizes is important to making something accessible to disabled people. A responsive design or even a scroll bar seems like a small accessibility change that would allow a lot more people to use your project. I'll try and make it myself, but I'm not the most skilled with this type of dev work :/

image

@triphora
Copy link
Contributor

triphora commented Jul 2, 2024

@io-tronic I am no longer a Modrinth staff member and therefore cannot reopen this issue. Please open a new issue.

Geometrically added a commit that referenced this issue Jul 4, 2024
@Geometrically @NeutronicMC
@triphora @ZachBaird @stairman06 @MagnusHJensen
Migrate to Nuxt 3 (#933)
740357d 
* Migrate to Nuxt 3

* Update vercel config

* remove tsconfig comment

* Changelog experiment + working proj pages

* Fix package json

* Prevent vercel complaining

* fix deploy (hopefully)

* Tag generator

* Switch to yarn

* Vercel pls 🙏

* Fix tag generation bug

* Make (most) non-logged in pages work

* fix base build

* Linting + state

* Eradicate axios, make most user pages work

* Fix checkbox state being set incorrectly

* Make most things work

* Final stretch

* Finish (most) things

* Move to update model value

* Fix modal text getting blurred from transforms (#964)

* Adjust nav-link border radius when focused (#961)

* Transition between animation states on TextLogo (#955)

* Transition between animation states on TextLogo

* Remove unused refs

* Fixes from review

* Disable tabbing to pagination arrows when disabled (#972)

* Make position of the "no results" text on grid/gallery views consistent (fixes #963) (#965)

* Fix position of the "no results" text on grid view

* fix padding

* Remove extra margin on main page, fixes #957 (#959)

* Fix layout shift and placeholder line height (#973)

* Fix a lot of issues

* Fix more nuxt 3 issues

* fix not all versions showing up (temp)

* inline inter css file

* More nuxt 3 fixes

* [skip ci] broken- backup changes

* Change modpack warnings to blue instead of red (#991)

* Fix some hydration issues

* Update nuxt

* Fix some images not showing

* Add pagination to versions page + fix lag

* Make changelog page consistent with versions page

* sync before merge

* Delete old file

* Fix actions failing

* update branch

* Fixes navbar transition animation. (#1012)

* Fixes navbar transition animation.

* Fixes Y-axis animation. Fixes mobile menu. Removes highlightjs prop.

* Changes xss call to renderString.

* Fixes renderString call.

* Removes unnecessary styling.

* Reverts mobile nav change.

* Nuxt 3 Lazy Loading Search (#1022)

* Uses lazyFetch for results. onSearchChange refreshes. Adds loading circle.

* Removes console.log

* Preserves old page when paging.

* Diagnosing filtering bugs.

* Fix single facet filtering

* Implements useAuth in settings/account.

* tiny ssr fix

* Updating nuxt.config checklist.

* Implements useAuth in revenue, moneitzation, and dashboard index pages.

* Fixes setups.

* Eliminates results when path changes. Adds animated logo.

* Ensures loading animation renders on search page.

---------

Co-authored-by: Jai A <jaiagr+gpg@pm.me>

* Fix navigation issues

* Square button fix (#1023)

* Removes checklist from nuxt.config.

* Modifies Nuxt CI to build after linting.

* Fixes prettierignore file.

* bug fixes

* Update whitelist domains

* Page improvements, fix CLS

* Fix a lot of things

* Fix project type redirect

* Fix 404 errors

* Fix user settings + hydration error

* Final fixes

* fix(creator-section): border radius on icons not aligning with bg (#1027)

Co-authored-by: MagnusHJensen <magnus.holm.jensen@lego.dk>

* Improvements to the mobile navbar (#984)

* Transition between animation states on TextLogo

* Remove unused refs

* Fixes from review

* Improvements to the mobile nav menu

* fix avatar alt text

* Nevermind, got confused for a moment

* Tab bar, menu layout improvements

* Highlight search icon when menu is open

* Update layouts/default.vue

Co-authored-by: Magnus Jensen <magnushjensen.mail@gmail.com>

* Fix some issues

* Use caret instead

* Run prettier

* Add create a project

---------

Co-authored-by: Magnus Jensen <magnushjensen.mail@gmail.com>
Co-authored-by: Geometrically <18202329+Geometrically@users.noreply.github.com>
Co-authored-by: Jai A <jaiagr+gpg@pm.me>

* Fix mobile menu issues

* More issues

* Fix lint

---------

Co-authored-by: Kaeden Murphy <kmurphy@kaedenmurphy.dev>
Co-authored-by: triphora <emmaffle@modrinth.com>
Co-authored-by: Zach Baird <30800863+ZachBaird@users.noreply.github.com>
Co-authored-by: stairman06 <36215135+stairman06@users.noreply.github.com>
Co-authored-by: Zachary Baird <zdb1994@yahoo.com>
Co-authored-by: Magnus Jensen <magnushjensen.mail@gmail.com>
Co-authored-by: MagnusHJensen <magnus.holm.jensen@lego.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
4 participants
@io-tronic @triphora @w26ad @Nachtwind1