From c899436741a3d2ab164aa4081eab8c99f01a5f85 Mon Sep 17 00:00:00 2001 From: Will Beebe Date: Mon, 28 Oct 2019 18:24:49 +0000 Subject: [PATCH] Adding "name" to Cloud Build resource Signed-off-by: Modular Magician --- docs/resources/google_cloudbuild_trigger.md | 2 ++ docs/resources/google_cloudbuild_triggers.md | 1 + libraries/google_cloudbuild_trigger.rb | 2 ++ libraries/google_cloudbuild_triggers.rb | 2 ++ 4 files changed, 7 insertions(+) diff --git a/docs/resources/google_cloudbuild_trigger.md b/docs/resources/google_cloudbuild_trigger.md index 8f22b8c98..b0375dff1 100644 --- a/docs/resources/google_cloudbuild_trigger.md +++ b/docs/resources/google_cloudbuild_trigger.md @@ -28,6 +28,8 @@ Properties that can be accessed from the `google_cloudbuild_trigger` resource: * `id`: The unique identifier for the trigger. + * `name`: Name of the trigger. Must be unique within the project. + * `description`: Human-readable description of the trigger. * `disabled`: Whether the trigger is disabled or not. If true, the trigger will never result in a build. diff --git a/docs/resources/google_cloudbuild_triggers.md b/docs/resources/google_cloudbuild_triggers.md index 0ba4f33e4..a1080c56e 100644 --- a/docs/resources/google_cloudbuild_triggers.md +++ b/docs/resources/google_cloudbuild_triggers.md @@ -27,6 +27,7 @@ Properties that can be accessed from the `google_cloudbuild_triggers` resource: See [google_cloudbuild_trigger.md](google_cloudbuild_trigger.md) for more detailed information * `ids`: an array of `google_cloudbuild_trigger` id + * `names`: an array of `google_cloudbuild_trigger` name * `descriptions`: an array of `google_cloudbuild_trigger` description * `disableds`: an array of `google_cloudbuild_trigger` disabled * `create_times`: an array of `google_cloudbuild_trigger` create_time diff --git a/libraries/google_cloudbuild_trigger.rb b/libraries/google_cloudbuild_trigger.rb index 5d35e687f..bf011b7e9 100644 --- a/libraries/google_cloudbuild_trigger.rb +++ b/libraries/google_cloudbuild_trigger.rb @@ -26,6 +26,7 @@ class CloudBuildTrigger < GcpResourceBase attr_reader :params attr_reader :id + attr_reader :name attr_reader :description attr_reader :disabled attr_reader :create_time @@ -45,6 +46,7 @@ def initialize(params) def parse @id = @fetched['id'] + @name = @fetched['name'] @description = @fetched['description'] @disabled = @fetched['disabled'] @create_time = parse_time_string(@fetched['createTime']) diff --git a/libraries/google_cloudbuild_triggers.rb b/libraries/google_cloudbuild_triggers.rb index a4771c814..ba47280a4 100644 --- a/libraries/google_cloudbuild_triggers.rb +++ b/libraries/google_cloudbuild_triggers.rb @@ -24,6 +24,7 @@ class CloudBuildTriggers < GcpResourceBase filter_table_config = FilterTable.create filter_table_config.add(:ids, field: :id) + filter_table_config.add(:names, field: :name) filter_table_config.add(:descriptions, field: :description) filter_table_config.add(:disableds, field: :disabled) filter_table_config.add(:create_times, field: :create_time) @@ -73,6 +74,7 @@ def transform(key, value) def transformers { 'id' => ->(obj) { return :id, obj['id'] }, + 'name' => ->(obj) { return :name, obj['name'] }, 'description' => ->(obj) { return :description, obj['description'] }, 'disabled' => ->(obj) { return :disabled, obj['disabled'] }, 'createTime' => ->(obj) { return :create_time, parse_time_string(obj['createTime']) },