Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with default border for newbies #26

Closed
moeenio opened this issue Jul 10, 2019 · 6 comments · Fixed by #53
Closed

Dealing with default border for newbies #26

moeenio opened this issue Jul 10, 2019 · 6 comments · Fixed by #53
Labels
in discussion Will be fixed somewhat, but is in discussion. medium priority Important, but not critical
Milestone
v1.0.0-beta.2

Comments

@moeenio
Copy link
Owner

moeenio commented Jul 10, 2019

I got this message :
Screenshot_2019-07-10 emojicom 🤙 - Collect feedback using emojis

Basically, we have two possibilities :

  1. Showing how to remove the border on the site
  2. Giving a code without border

Any advice @Andreto @MasterOfTheTiger @kennethsweezy ?
@MasterOfTheTiger
Copy link

Can you specify what you are talking about? Maybe a screenshot?

@Andreto
Copy link
Contributor

Andreto commented Jul 10, 2019

Maybe a checkbox for "Frame Styling". When it's checked they get the code with our custom styling and if it's unchecked they get the blank code.

@moeenio
Copy link
Owner Author

moeenio commented Jul 10, 2019

Can you specify what you are talking about? Maybe a screenshot?

I'm talking about the default iframe border.

@MasterOfTheTiger
Copy link

@locness3 Okay. So a button toggle would be the best solution in my opinion.

@moeenio
Copy link
Owner Author

moeenio commented Jul 12, 2019 •
edited
Loading

Don't you think giving a code without border and no other one would be sufficient ?

@MasterOfTheTiger
Copy link

Don't you think giving a code without border and no other one would be sufficient ?

I think you are right, unless there is a good reason to keep the border.

@moeenio moeenio added the in discussion Will be fixed somewhat, but is in discussion. label Jul 13, 2019
@moeenio moeenio pinned this issue Jul 26, 2019
@moeenio moeenio added the medium priority Important, but not critical label Dec 25, 2019
@moeenio moeenio mentioned this issue Jan 5, 2020
Merged
@moeenio moeenio added this to the v1.0.0-beta.2 milestone Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in discussion Will be fixed somewhat, but is in discussion. medium priority Important, but not critical
Projects
None yet
Milestone
v1.0.0-beta.2
Development

Successfully merging a pull request may close this issue.

Changing the default iframe border to a better-looking one moeenio/scratch-profile-embed
3 participants
@MasterOfTheTiger @Andreto @moeenio