You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, I was messing around with the dashboard settings and found a few things that could be improved.
If you upload a horizontal profile picture it looks compressed.
If you try to upload an invalid image (filename has space) it doesn't show any error.
Short bio is initially blank, so it should be an optional field. Right now, If you try to change my profile picture or name, you are also forced to add a short bio.
If you try to leave a dirty form, there should be a confirmation dialog.
I would like to open a PR to address these.
Though I'm not sure how to deal with number 4. I did some research and there's this window event called beforeunload but it doesn't seem to trigger for next router. And the new Next 13 router doesn't support events yet (maybe it will be possible after they add router events?)
What do you think?
The text was updated successfully, but these errors were encountered:
Thanks for addressing these issues. I checked and I think we can skip 1, 2 and you can work on 3rd now and 4th when router events will be supported in App router.
Hey, I was messing around with the dashboard settings and found a few things that could be improved.
I would like to open a PR to address these.
Though I'm not sure how to deal with number 4. I did some research and there's this window event called
beforeunload
but it doesn't seem to trigger for next router. And the new Next 13 router doesn't support events yet (maybe it will be possible after they add router events?)What do you think?
The text was updated successfully, but these errors were encountered: