Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard settings QOL #49

Closed
zahid47 opened this issue Jul 29, 2023 · 1 comment · Fixed by #51
Closed

Dashboard settings QOL #49

zahid47 opened this issue Jul 29, 2023 · 1 comment · Fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@zahid47
Copy link
Contributor

zahid47 commented Jul 29, 2023

Hey, I was messing around with the dashboard settings and found a few things that could be improved.

  1. If you upload a horizontal profile picture it looks compressed.
  2. If you try to upload an invalid image (filename has space) it doesn't show any error.
  3. Short bio is initially blank, so it should be an optional field. Right now, If you try to change my profile picture or name, you are also forced to add a short bio.
  4. If you try to leave a dirty form, there should be a confirmation dialog.

I would like to open a PR to address these.

Though I'm not sure how to deal with number 4. I did some research and there's this window event called beforeunload but it doesn't seem to trigger for next router. And the new Next 13 router doesn't support events yet (maybe it will be possible after they add router events?)

What do you think?

@moinulmoin
Copy link
Owner

Thanks for addressing these issues. I checked and I think we can skip 1, 2 and you can work on 3rd now and 4th when router events will be supported in App router.

@moinulmoin moinulmoin added the enhancement New feature or request label Jul 30, 2023
@moinulmoin moinulmoin linked a pull request Jul 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants