-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Range Slider
Component
#110
Comments
Kindly assign me |
Go ahead, @anjali1102 ! |
Hey @anjali1102 , Do you have any progress on this? If timing is bad for you, maybe I should un-assign you so someone else can take this? |
hi @sohamsshah I am unable to see any changes on my localhost or http://127.0.0.1:8000/flint/configurations/point |
Hi @anjali1102 , are you working on this? If it is not a good time for you at the moment, please feel free to let us know 😊 |
Hey @Chicken-Biryani @sohamsshah I would like to work on this issue if no one's working on it. 😄 |
@yashsehgal , sure go ahead! I would suggest first lets brainstorm a bit on what props can be added for our implementation of Range Slider component. We can refer some popular design systems to decide the component Design. |
Yeah sure @sohamsshah I will create and share a list of features we can add to this component, according to our requirements. |
Could we replace the range slider with text boxes? Because-
Just a thought. I think putting a text box would be better. Or maybe we could keep the range slider and put a text box below that. |
Great idea. What we do is create a component wrapper with 2 radio based options (custom and range) so that by default users can set a range value, if they want custom then after selecting the custom radio button an input box will appear. If this sounds to be a good approach, I can start designing it. |
This sounds good. Though, we can design the RangeSlider component that accepts props which manage with props such as:
Personally, I find the |
The problem is that... it limits the user. The values can go way beyond (negative and positive)..... I don't know whether having a range slider is useful, eventually. But okay let's go with Soham's idea. |
If that is the case, then it would be better to take help from designer for the final UI for the requested component. Once it is confirmed, then only it would make sense to actually write code for the component. |
Correct 💯 |
I have created a concept wireframe of this component.
This is how the design is looking, you can also check it on figma here |
Hey @Chicken-Biryani @sohamsshah |
Hey @yashsehgal , this seems great. Sure, please raise a PR for this component, it would be great! |
Hey @sohamsshah https://codesandbox.io/s/elated-dawn-hhdmz?file=/src/App.vue If it looks good to you, I can start implementing this feature into our codebase. Tools I have used: ChakraUI for Vue Here's some SS of the current component design |
Hey @yashsehgal , I see that you have used Chakra-UI Vue for this. The implementation looks good but I feel that the decision about the design system is still awaiting (See comments here #136 ) Once it is finalized, we can move forward with this. |
@sohamsshah i would like to work on this issue :) |
Hi, @Palaksharma23 we have a new issue with similar instructions but I believe revolving around what we require lately. I'll close this one. |
Is your feature request related to a problem? Please describe.
According to the new design update, we are aiming to develop an updated version for Slider Component.
Currently our slider component looks something like:
Describe the solution you'd like.
We want to create new component like this (with tailwind css):
Describe alternatives you've considered
The current slider component lies in
flint.ui/src/components/Sliders
. The new Slider Component should be added in this folder (no need to delete other component files.) Test this by updating the views on/flint/configurations/point
etc. routes to ensure working of the component.Additional context.
Make sure the component:
tailwind.config.js
file to extend new theme if needed(Feel Free to ask questions or curiosities around its implementation.
The text was updated successfully, but these errors were encountered: