Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Date Picker Component #112

Closed
sohamsshah opened this issue Nov 14, 2021 · 7 comments
Closed

Create Date Picker Component #112

sohamsshah opened this issue Nov 14, 2021 · 7 comments
Assignees
Labels
beginner friendly Basic issues that welcome new-comers enhancement New feature or request good first issue Good for newcomers

Comments

@sohamsshah
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Currently, the date-picker component looks like:
image

Describe the solution you'd like.

We are aiming for this component design as per latest design update for flint.ui
image

Describe alternatives you've considered

Create this component in the flint.ui/src/components/. You can take reference from other components available in the folder. (don't delete any other component files)

Additional context.

Make sure that:

  • Use Tailwindcss utility classes
  • Proper Props and Implementation
  • Test the component by seeing the working at different places where this is used

Feel Free to ask questions or curiosities around its implementation.

@sohamsshah sohamsshah added the enhancement New feature or request label Nov 14, 2021
@shloka-gupta shloka-gupta added beginner friendly Basic issues that welcome new-comers good first issue Good for newcomers labels Nov 14, 2021
@Dangpham0305
Copy link

assign me. I think i can help you

@shloka-gupta
Copy link
Member

@Dangpham0305 sure go ahead!

@sohamsshah
Copy link
Collaborator Author

Hey @Dangpham0305 , any updates on this? If timing is bad for you, maybe I should un-assign you so someone else can take this?

@yashsehgal
Copy link
Contributor

Hey @Chicken-Biryani @sohamsshah I would like to work on this issue. Can you please assign this to me 😄

@shloka-gupta
Copy link
Member

Yes, @yashsehgal go ahead

@yashsehgal
Copy link
Contributor

Hey, Can I add a prop for providing width to the date-picker component. Like

<date-picker-point inputWidth="small" />
// means width - 30% from the parent container
<date-picker-point inputWidth="medium" />
// means width - 60% from the parent container
<date-picker-point inputWidth="large" />
// means width - 100% from the parent container

@sohamsshah
Copy link
Collaborator Author

Hey, Can I add a prop for providing width to the date-picker component. Like

<date-picker-point inputWidth="small" />
// means width - 30% from the parent container
<date-picker-point inputWidth="medium" />
// means width - 60% from the parent container
<date-picker-point inputWidth="large" />
// means width - 100% from the parent container

Yes, this looks good. Will add flexibility for building the diff frontend in future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner friendly Basic issues that welcome new-comers enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants