Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin should not check test classes by default #142

Closed
jtnord opened this issue Feb 3, 2021 · 1 comment · Fixed by #143
Closed

plugin should not check test classes by default #142

jtnord opened this issue Feb 3, 2021 · 1 comment · Fixed by #143

Comments

@jtnord
Copy link
Contributor

jtnord commented Feb 3, 2021

#80 introduced the ability to check test classes, however it defaulted this to on.

this is a change in behaviour - and for the most part I would argue that using newer APIs in test code that does not get delivered as part of the product is completely acceptable. (there are situations where you do push a test-jar that you may want this check enabled for - but this would not be the normal)

therefore the brhaviour should default to off so that configuration by convention wins for the majority of the projects
jtnord added a commit to jtnord/animal-sniffer that referenced this issue Feb 3, 2021
@jtnord
checking test code is disabled by default
6456a21 
fixes mojohaus#142
@jtnord jtnord mentioned this issue Feb 3, 2021
Merged
@olamy olamy closed this as completed in #143 Feb 9, 2021
olamy pushed a commit that referenced this issue Feb 9, 2021
@jtnord
checking test code is disabled by default (#143)
ac40ac4 
* checking test code is disabled by default

fixes #142

* fix the mojo and IT
@famod
Copy link
Contributor

famod commented Feb 10, 2021

The main idea was to have it consistent, especially for cases where developer A is working on a project with JDK 8 and another developer B is working with JDK 11, which is not that rare for smaller open source projects.
So this aspect is not about shipping/delivering.

I hope there will be a clear note in the changelog, otherwise people might not realize they now have to enable the property. /cc @olamy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

checking test code is disabled by default jtnord/animal-sniffer
2 participants
@jtnord @famod