Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#632 Second batch of maintenance following PR #672 #711

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

sultan
Copy link
Contributor

@sultan sultan commented Sep 19, 2022

Second batch of maintenance following PR #672.

"as a result of fixing #632, it appears we could maybe get rid of the class MajorMinorIncrementalFilter which states that its very existence is filtering milestones and RC from the result of the calls, when they are in the wrong major, but they are now already filtered out by the corrected boundaries."

@sultan sultan force-pushed the MoreFixings branch 2 times, most recently from 8c2ef6e to 14e69b9 Compare September 19, 2022 12:07
@sultan sultan marked this pull request as draft September 19, 2022 12:09
@sultan
Copy link
Contributor Author

sultan commented Sep 28, 2022

UseLatestReleasesMojo : applied, it tests ok.
UseLatestSnapshotsMojo : applied, it tests ok.
UseLatestVersionsMojo : more refactoring needed, untouched.

MajorMinorIncrementalFilter still there but for only one feature, might delete later.

@sultan sultan marked this pull request as ready for review September 28, 2022 16:06
@slawekjaranowski slawekjaranowski merged commit 37e8947 into mojohaus:master Sep 29, 2022
@slawekjaranowski slawekjaranowski added this to the 2.13.0 milestone Sep 29, 2022
@sultan sultan deleted the MoreFixings branch October 18, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants