From 3dbba7cdd4454fe804ea9e686693bf024212cfd5 Mon Sep 17 00:00:00 2001 From: Swell <5782559+sultan@users.noreply.github.com> Date: Thu, 20 Jan 2022 11:09:53 +0100 Subject: [PATCH 1/2] Fixed #536 : Regression in the maven site rendering due to Doxia change to HTML 5 --- .../mojo/versions/AbstractVersionsReportRenderer.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java b/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java index 0931a46457..20c22a5824 100644 --- a/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java +++ b/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java @@ -97,16 +97,18 @@ public String getText( String key ) protected void renderWarningIcon() { - sink.figure(); + // a rendering regression was fixed here, + // putting figure back will reintroduce the regression. + // https://github.com/mojohaus/versions-maven-plugin/issues/536 sink.figureGraphics( "images/icon_warning_sml.gif" ); - sink.figure_(); } protected void renderSuccessIcon() { - sink.figure(); + // a rendering regression was fixed here, + // putting figure back will reintroduce the regression. + // https://github.com/mojohaus/versions-maven-plugin/issues/536 sink.figureGraphics( "images/icon_success_sml.gif" ); - sink.figure_(); } protected boolean equals( ArtifactVersion v1, ArtifactVersion v2 ) From afb693f679d98e06950db395b908d737ae625290 Mon Sep 17 00:00:00 2001 From: Swell <5782559+sultan@users.noreply.github.com> Date: Thu, 20 Jan 2022 15:45:39 +0100 Subject: [PATCH 2/2] Fixed #536 : Regression in the maven site rendering due to Doxia change to HTML 5 --- .../mojo/versions/AbstractVersionsReportRenderer.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java b/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java index 20c22a5824..b7bca23459 100644 --- a/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java +++ b/src/main/java/org/codehaus/mojo/versions/AbstractVersionsReportRenderer.java @@ -97,17 +97,11 @@ public String getText( String key ) protected void renderWarningIcon() { - // a rendering regression was fixed here, - // putting figure back will reintroduce the regression. - // https://github.com/mojohaus/versions-maven-plugin/issues/536 sink.figureGraphics( "images/icon_warning_sml.gif" ); } protected void renderSuccessIcon() { - // a rendering regression was fixed here, - // putting figure back will reintroduce the regression. - // https://github.com/mojohaus/versions-maven-plugin/issues/536 sink.figureGraphics( "images/icon_success_sml.gif" ); }