Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test suite for Phoenix 1.6 #278

Closed
2 of 3 tasks
cpjolicoeur opened this issue Jan 1, 2022 · 1 comment
Closed
2 of 3 tasks

Update test suite for Phoenix 1.6 #278

cpjolicoeur opened this issue Jan 1, 2022 · 1 comment

Comments

@cpjolicoeur
Copy link
Member

cpjolicoeur commented Jan 1, 2022

Add PHX 1.6 sample app to test suite and refactor generator code to be easier to handle new Phoenix versions going forward.

At this point, I'm thinking it might be OK, and make sense, to just cut a v4.0 release of Torch that only supports Phoenix 1.6+ and the supported Elixir versions (1.9+).

The current v3 version of Torch is pretty stable at this point, and we can easily maintain it for the near future for security updates an bug fixes without much problem.

If we are going to drop backwards-compatibility and do a v4 release it would also afford us the opportunity to change other things as it will be a major release. Now, I'd prefer the upgrade path from Torch v3 to v4 for users already on Phx 1.6 or 1.5 to be as painless as possible (i.e. require no, or minimal code changes), so the core public API's and things should remain supported if possible.


  • Add Phoenix 1.6 example app to test suite
  • Drop generator code supporting Phx < 1.6 and/or Elixir < 1.9
  • Support LiveView templates for Torch admin?
@cpjolicoeur
Copy link
Member Author

closed via [#325]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant