Skip to content

Commit

Permalink
Update contributing.md (dataform-co#1446)
Browse files Browse the repository at this point in the history
* Added includeDependents flag to run command

* Highlight that dev branches should branch off main
  • Loading branch information
a2wd committed Feb 13, 2023
1 parent 87cd3d3 commit 0071fa5
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,9 @@ The projects folder here is not built as it requires an environment file, which

1. Begin materialising your masterpiece.

1. Once done, merge from main, review your code, run the tests, **[check for common mistakes](#common-pull-request-mistakes)** and then open a pull request.
1. Create a feature branch based on `main` ([link](https://github.com/dataform-co/dataform/tree/main)) for development work.

1. Once done, review your code, run the tests, **[check for common mistakes](#common-pull-request-mistakes)** and then open a pull request.

1. Tidy the code by removing erronous log statements. Comment difficult to interpret sections. Make sure functions are names appropriately. We will review the pull request mainly by the git difference.

Expand Down

0 comments on commit 0071fa5

Please sign in to comment.