From 0071fa59f2fa4248407cfce892201bd257c1a9e5 Mon Sep 17 00:00:00 2001 From: Alito Alvarez Date: Mon, 13 Feb 2023 12:12:08 +0000 Subject: [PATCH] Update contributing.md (#1446) * Added includeDependents flag to run command * Highlight that dev branches should branch off main --- contributing.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contributing.md b/contributing.md index 631c2dade..c07fde434 100644 --- a/contributing.md +++ b/contributing.md @@ -74,7 +74,9 @@ The projects folder here is not built as it requires an environment file, which 1. Begin materialising your masterpiece. -1. Once done, merge from main, review your code, run the tests, **[check for common mistakes](#common-pull-request-mistakes)** and then open a pull request. + 1. Create a feature branch based on `main` ([link](https://github.com/dataform-co/dataform/tree/main)) for development work. + +1. Once done, review your code, run the tests, **[check for common mistakes](#common-pull-request-mistakes)** and then open a pull request. 1. Tidy the code by removing erronous log statements. Comment difficult to interpret sections. Make sure functions are names appropriately. We will review the pull request mainly by the git difference.