Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report has value "Unknown" for assembly in VIP 5.2 #120

Closed
bartcharbon opened this issue Mar 31, 2023 · 1 comment
Closed

Report has value "Unknown" for assembly in VIP 5.2 #120

bartcharbon opened this issue Mar 31, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@bartcharbon
Copy link
Member

Report has value "Unknown" for assembly in VIP 5.2.0

@dennishendriksen dennishendriksen added the bug Something isn't working label Apr 17, 2023
@dennishendriksen
Copy link
Contributor

The default molgenis/vip-report-template displays the value of the assembly field returned by api.getHtsFileMetadata(). molgenis/vip-report populates this field using org.molgenis.vcf.utils.sample.mapper.HtsFileMapper from molgenis/vip-utils which tries to extract the assembly value from the 1.4.6 Assembly field.

According to this specification this field is meant for Breakpoint assemblies for structural variations may use an external file and the value is an url from which follows that the current implementation is using the wrong field.

Since the assembly is not stored in the input .vcf and is not passed as a command-line argument to vip-report the value Unknown is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants