Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http response writeable stream not ending when used in pipeline (node >= 11.1.0) #67

Open
kevinmstephens opened this issue Jul 10, 2020 · 2 comments
Open

http response writeable stream not ending when used in pipeline (node >= 11.1.0) #67

kevinmstephens opened this issue Jul 10, 2020 · 2 comments

Comments

@kevinmstephens
Copy link

We are seeing an issue with MITM involving:

  • HTTPS requests (does not impact HTTP)
  • Starting in Node 11.1 and continuing to current Node 14 (11.0.0 and prior works fine)

When we use the http response writeable stream provided by MITM in the nodejs internal streams pipeline method the pipeline callback is never invoked.

We have created a repo with an implementation and tests showing the problem. If you run yarn test with node v11.0.0 the tests will pass, if you run with v11.1.1 they will timeout.

https://github.com/FormidableLabs/mitm-experiments

The callback not invoked that should be is here: https://github.com/FormidableLabs/mitm-experiments/blob/main/index.js#L126

Thanks for your help!
@kevinmstephens kevinmstephens mentioned this issue Jul 10, 2020
Open
@moll
Copy link
Owner

moll commented Jul 15, 2020

Hey,

Thanks for the report. I'll see what I can find out!

@Burnett2k
Copy link

Hi @moll . Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@moll @Burnett2k @kevinmstephens