Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination support to all resources #25

Closed
karensg opened this issue May 14, 2016 · 8 comments
Closed

Add pagination support to all resources #25

karensg opened this issue May 14, 2016 · 8 comments
Milestone

Comments

@karensg
Copy link

karensg commented May 14, 2016

Hi,

How do I pass the count and offset parameters to Payment LIST method. So far I can see, it is not implemented as

mollie.payments.all

does not accept any parameters.

Thanks

@Daanvm
Copy link
Contributor

Daanvm commented Aug 26, 2016

Hi Karens,
Thanks for pointing this out and apologies for the late reply!

I think you're right, we should add support for pagination to all resources, not only the payments LIST method.

@Daanvm Daanvm changed the title Pagination for payments Add pagination support to all resources Aug 26, 2016
@benoist
Copy link
Contributor

benoist commented Oct 13, 2016

perhaps milestone 2.0.1

@Daanvm Daanvm added this to the 2.1.0 milestone Oct 13, 2016
@Daanvm
Copy link
Contributor

Daanvm commented Oct 13, 2016

I agree, except that new features would require a MINOR version bump instead of a PATCH bump.

@karensg
Copy link
Author

karensg commented Dec 5, 2016

Hi guys,

Do you have any update on this functionality? I think it should be possible to pass all kind of parameters to the GET endpoints in general. It would make this gem much more usable.

Karens

@martijncasteel
Copy link

I would also like to now when it is possible to pass count and limit to the list function.

@Daanvm
Copy link
Contributor

Daanvm commented Feb 6, 2017

@brambokdam fixed this in PR #51, thanks!

I'll create a new release later today.

@Daanvm
Copy link
Contributor

Daanvm commented Feb 6, 2017

Release 2.1.0 is created. It's also released as gem at RubyGems.

@Daanvm Daanvm closed this as completed Feb 6, 2017
@karensg
Copy link
Author

karensg commented Feb 6, 2017

Thanks, could finally send the locale parameter to the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants