Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use non-AMOLED dark theme #128

Closed
1 task done
BayLee4 opened this issue Sep 5, 2022 · 13 comments
Closed
1 task done

Add option to use non-AMOLED dark theme #128

BayLee4 opened this issue Sep 5, 2022 · 13 comments
Labels
feature-request New feature or request help-wanted Good contribution opportunities

Comments

@BayLee4
Copy link

BayLee4 commented Sep 5, 2022

Is there an existing request for this?

  • I have searched the existing issues

Feature description

Hi,
Molly changed the default background color for the dark theme from #1B1C1F to #000000 (I guess to match the system AMOLED black style, removed since Android 12). Would it be possible to have an option to use the original background color? For some reason I find it more difficult to read with the pure black theme. Thank you!

@BayLee4 BayLee4 added the feature-request New feature or request label Sep 5, 2022
@BayLee4
Copy link
Author

BayLee4 commented Sep 15, 2022

Or alternatively and more simply, would reverting the background color to #1B1C1F be an acceptable solution?

@valldrac
Copy link
Member

You're right. Molly should keep the original background color for easy readability. But many Molly users already love the true black theme.

It would be awesome if someone can contribute to this feature. We need to add a 2nd dark theme and develop an script to sync them. A gradle task preferably. This would fix the burden of maintaining an additional theme.

@Silther
Copy link

Silther commented Jan 12, 2023

The question is, should we wait until signal implements material you theming?

@Cod3dDOT
Copy link

Cod3dDOT commented Jul 20, 2023

Any updates on this? Would love to see material you implemented.

@BayLee4 BayLee4 mentioned this issue Oct 20, 2023
1 task
@ghost
Copy link

ghost commented Dec 13, 2023

Hey, I personally love the true black background and couldn't live without it, but my friend would like to have original one, how hard would it be to add a 3 option?

@ThatOneCalculator
Copy link

The question is, should we wait until signal implements material you theming?

I don't think they'll ever add it... It'd be nice if Molly added Material You, since MD3 is already used

@valldrac
Copy link
Member

valldrac commented Mar 5, 2024

Seems like the AMOLED theme could be improved as well. Someone on Twitter reported it.

@ghost
Copy link

ghost commented Apr 19, 2024

👀

@itsmartashub
Copy link

itsmartashub commented Apr 19, 2024

Oh my, what's the reason behind removing the AMOLED theme? Was there too much pressure from users to revert to the original color? Or perhaps you anticipated that Signal might soon implement dynamic Material You, so you avoided the complications and user demands that could arise from that?
Is there any plan to introduce an OLED theme (again) alongside the Dark one in the near future, or is that it? Honestly, this is one of the main reasons why I use Molly, deng 😭

@Silther
Copy link

Silther commented Apr 19, 2024

Must say that the only reason why I don't use molly on all my devices is the oled theme.

@itsmartashub
Copy link

itsmartashub commented Apr 19, 2024

Must say that the only reason why I don't use molly on all my devices is the oled theme.

Sorry @Silther, I just find this funny because it seems like your Github profile picture is AMOLED (completely black)? 😭

@Silther
Copy link

Silther commented Apr 19, 2024

Sorry @Silther, I just find this funny because it seems like your Github profile picture is AMOLED (completely black)? 😭

I fear that's only because of a lack of creativity 😅

@valldrac
Copy link
Member

There are several reasons why we decided to remove this feature. We've been discussing them in our Matrix channel lately. Basically, everyone agrees that true black background should be optional, meaning we should add a second dark theme to the app. This is because AMOLED-friendly themes goes against the industry trend and affects the usability for many users, as seen in this issue report.

The question now goes around the cost of implementing a second dark theme in Molly. With the current theme system, it's messy and the maintenance costs are high. This might improve in the future, and if there's still demand for this feature, we'll consider reintroducing it. But this time, it'll be done properly, as an optional choice. If any developer wants to step up, implement, and maintain this feature, we'd love to have it back.

The background color we picked for the dark theme isn't pure black, but it's not as brightness as Signal's original. It's a bit darker.

Thanks for your understanding!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request help-wanted Good contribution opportunities
Development

No branches or pull requests

6 participants