Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Australian timezones not correct? #108

Closed
mikehdt opened this issue Jul 23, 2014 · 7 comments
Closed

Australian timezones not correct? #108

mikehdt opened this issue Jul 23, 2014 · 7 comments

Comments

@mikehdt
Copy link

mikehdt commented Jul 23, 2014

Hi,

I'm not sure if Moment is using a different standards system, and I'm certainly no expert on timezone systems - but as an Australian, I'm used to referring to the eastern timezone as AEST (UTC+10), so it's not confused with the US EST (UTC-5). For the states such as Victoria and NSW which observe daylight savings (Queensland does not), the timezone becomes AEDT (UTC+11).

At the moment, Moment refers to both as EST, whether daylight savings is being observed or not (EST as +10 and also EST as +11, which is really confusing!).

Official-ish Australian government reference of timezones can be found here:
http://australia.gov.au/about-australia/our-country/time

Thanks!

@timrwood
Copy link
Member

We use the data from http://www.iana.org/time-zones directly, so whatever is used there will be reflected in moment-timezone.

It looks like this change has already been made on 2014-06-30. eggert/tz@62df86e

See the comments here. eggert/tz@62df86e#diff-7a413a97538e4a2a88ec6c08dd067830R869

The 2014e timezone data was released on 2014-06-12, so it looks like this just missed the cut and will be in the next data release. When it does, I'll release a moment-timezone@0.2.1 with the new data.

@timrwood
Copy link
Member

timrwood commented Sep 4, 2014

See #126 which should resolve this.

@timrwood
Copy link
Member

timrwood commented Sep 4, 2014

This was released with moment-timezone@0.2.2, let me know if you have any issues.

@timrwood timrwood closed this as completed Sep 4, 2014
@monicaraghuwanshi
Copy link

@timrwood this issue seems to be happening again. I am getting (+11:00 UTC) Australia/Sydney . Please help me out.

@sdsdsd3951
Copy link

@timrwood we also have the same issue, some Australian states do not observe daylight savings but are included none the less.

@darrylsepeda
Copy link

darrylsepeda commented Apr 17, 2023

and now 2023, I bump into the same issue from 9 years ago

@gilmoreorless
Copy link
Member

@darrylsepeda Double check if your project is including a file called moment-timezone-with-data-2012-2022.js (or .min.js). You might need to switch to a different file source, see moment/moment#6111 (comment) for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants