Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified longDateFormat.LT format 'mm' to 'm' #1800

Closed
wants to merge 1 commit into from

Conversation

kyungw00k
Copy link

It's little bit awkward to show 'minutes' in two digits.
So, it need to be modified to show like 2[minute], not 02[minute].

It's little bit awkward to show 'minutes' in two digits.
So, it need to be modified to show like 2[minute], not 02[minute].
@ichernev
Copy link
Contributor

ichernev commented Aug 5, 2014

@kyungw00k what do you think?

@kyungw00k
Copy link
Author

@ichernev If time of now 15:02, it should print "오후 3시 2분" not "오후 3시 02분".
(오후 = Afternoon, 시 = hours, 분 = minutes)

@ichernev ichernev added this to the 2.8.2 milestone Aug 20, 2014
@ichernev
Copy link
Contributor

Ah, sorry. I didn't see you're the original author :)

Will merge in next patch release.

ichernev added a commit to ichernev/moment that referenced this pull request Aug 20, 2014
@changelog
@section lang-bugfix
@description Use 'm' instead of 'mm' in longDateFormat in korean
@ichernev
Copy link
Contributor

Merged in d4d3d1f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants