-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[locale/ar] Use native plural forms #1801
Conversation
Closes #1799 |
Awesome! Looks like you'll need to update the tests to expect the right plural forms, though. |
@forabi, yes, please change the tests accordingly. |
@Oire I updated the tests |
@abdelsaid can you please verify this change |
Looks like he deleted his account. I understand you need some form of verification, but the old translations are the incorrect ones, they were simply a 1:1 translation of the English strings, many translators do not care enough to use the correct forms because either they do not know how to implement the correct forms or the code does not provide a way to implement them and they need to rewrite core functions to handle this case, which may not be easy. |
This looks good then. Will merge in next patch release. |
Merged in 25df5b3 |
No description provided.