Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tildes from core/scss and icons/scss #1454

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

shammy8
Copy link

@shammy8 shammy8 commented Jun 8, 2023

Description

Sass-loader has deprecated the use of tilde for awhile now: https://github.com/webpack-contrib/sass-loader#resolving-import-at-rules

Angular 15 has totally stopped supporting tilde as well: angular/angular-cli#25266 (comment)

This PR removes the tilde from scss files in the core and icons packages.

I have left a couple of tildes in for example the ones in the core/app and core/templates folder as these one doesn't seem to affect us. I'm guessing since they get compiled to something else before being consumed by the end user.

(edit) looks like just removing the ~ doesn't work as it can't compile the app in core/app. I have changed it to use relative paths instead.

Related Issue

#1453

Motivation and Context

Allows the library to be used with Angular 15+ projects

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.20 ⚠️

Comparison is base (80e95f9) 94.00% compared to head (4b10633) 93.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
- Coverage   94.00%   93.81%   -0.20%     
==========================================
  Files         132      132              
  Lines       18320    18320              
  Branches     2814     2809       -5     
==========================================
- Hits        17222    17186      -36     
- Misses       1098     1134      +36     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant