Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tab icon updates #1750

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Tab icon updates #1750

merged 4 commits into from
Aug 21, 2024

Conversation

NotNestor
Copy link
Collaborator

@NotNestor NotNestor commented Aug 21, 2024 •
edited
Loading

Description

  • Fix alignment of tabs. Text and icons are not aligned correctly and on moving to the new icon set it looks even worse

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):
Legacy font Icons
Screenshot 2024-08-21 at 16 56 35

momentum design svg icons
Screenshot 2024-08-21 at 16 58 10

After:

Legacy font Icons
Screenshot 2024-08-21 at 16 59 22

momentum design svg icons
Screenshot 2024-08-21 at 17 00 12

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@NotNestor NotNestor merged commit d76fea1 into momentum-design:master Aug 21, 2024
8 checks passed
@NotNestor NotNestor deleted the tabIconUpdates branch August 21, 2024 16:09
nithishkumar98 pushed a commit that referenced this pull request Aug 29, 2024
@NotNestor @nithishkumar98
Tab icon updates (#1750)
2e26803 
* chore: update tabs

* chore: persist selection of tab in sandbox. fix more margin

* chore: update alignment and truncation
parsoman pushed a commit to parsoman/momentum-ui that referenced this pull request Aug 29, 2024
@NotNestor @parsoman
Tab icon updates (momentum-design#1750)
e51f026 
* chore: update tabs

* chore: persist selection of tab in sandbox. fix more margin

* chore: update alignment and truncation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanSpillane AlanSpillane AlanSpillane approved these changes

@chogorma chogorma Awaiting requested review from chogorma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotNestor @AlanSpillane @jnestorCisco