Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

export all types in typescript declaration file and work around the fact typescript can't handle union of promise type #87

Merged
merged 4 commits into from
Mar 16, 2020

Conversation

xud6
Copy link
Contributor

@xud6 xud6 commented Mar 11, 2020

Export all types in typescript declaration file.
So they can be imported into applications.

Work around the fact typescript can't handle union of promise type.
Because typescript can't figure out Promise<void | string> equals Promise<void> | Promise<string>

@momocow momocow self-requested a review March 15, 2020 06:15
@momocow momocow changed the base branch from master to dev March 16, 2020 14:15
@momocow
Copy link
Owner

momocow commented Mar 16, 2020

Thanks, it will be released as soon as I check all the dependencies up-to-date.

@momocow momocow merged commit d0c76d3 into momocow:dev Mar 16, 2020
momocow added a commit that referenced this pull request Mar 23, 2020
inazuma-bot added a commit that referenced this pull request Mar 23, 2020
## [2.1.1](v2.1.0...v2.1.1) (2020-03-23)

### Bug Fixes

* Fix typing ([#87](#87)) and upgrade dependencies. ([bbb54ad](bbb54ad))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants