Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only default emojis shown on release notes #98

Open
Verhaeg opened this issue Mar 15, 2024 · 1 comment
Open

Only default emojis shown on release notes #98

Verhaeg opened this issue Mar 15, 2024 · 1 comment

Comments

@Verhaeg
Copy link

Verhaeg commented Mar 15, 2024

If I want to set a different set of emojis and use the default template it "works".. As in it generates the desired version, but the release notes are not generated as intended.

In our case we set several emojis as patch but only the :bug: is shown in the generated release notes.

Taking a quick look at the code, it seems it does not pass the releaseRules config when generating notes.

example config: .releaserc

{
  "branches": [
    "main"
  ],
  "plugins": [
    [
      "semantic-release-gitmoji",
      {
        "releaseRules": {
          "major": [
            "💥",
            ":boom:"
          ],
          "minor": [
            "",
            ":sparkles:"
          ],
          "patch": [
            "🎨",
            ":art:",
            "⚡️",
            ":zap:",
            "🔥",
            ":fire:",
            "🐛",
            ":bug:",
            "🚑️",
            ":ambulance:",
            "📝",
            ":memo:",
            "🚀",
            ":rocket:",
            "💄",
            ":lipstick:",
            "🎉",
            ":tada:",
            "",
            ":white_check_mark:",
            "🔒️",
            ":lock:",
            "🔐",
            ":closed_lock_with_key:",
            "🔖",
            ":bookmark:",
            "🚨",
            ":rotating_light:",
            "🚧",
            ":construction:",
            "💚",
            ":green_heart:",
            "⬇️",
            ":arrow_down:",
            "⬆️",
            ":arrow_up:",
            "📌",
            ":pushpin:",
            "👷",
            ":construction_worker:",
            "📈",
            ":chart_with_upwards_trend:",
            "♻️",
            ":recycle:",
            "",
            ":heavy_plus_sign:",
            "",
            ":heavy_minus_sign:",
            "🔧",
            ":wrench:",
            "🔨",
            ":hammer:",
            "🌐",
            ":globe_with_meridians:",
            "✏️",
            ":pencil2:",
            "💩",
            ":poop:",
            "⏪️",
            ":rewind:",
            "🔀",
            ":twisted_rightwards_arrows:",
            "📦️",
            ":package:",
            "👽️",
            ":alien:",
            "🚚",
            ":truck:",
            "📄",
            ":page_facing_up:",
            "🍱",
            ":bento:",
            "♿️",
            ":wheelchair:",
            "💡",
            ":bulb:",
            "🍻",
            ":beers:",
            "💬",
            ":speech_balloon:",
            "🗃️",
            ":card_file_box:",
            "🔊",
            ":loud_sound:",
            "🔇",
            ":mute:",
            "👥",
            ":busts_in_silhouette:",
            "🚸",
            ":children_crossing:",
            "🏗️",
            ":building_construction:",
            "📱",
            ":iphone:",
            "🤡",
            ":clown_face:",
            "🥚",
            ":egg:",
            "🙈",
            ":see_no_evil:",
            "📸",
            ":camera_flash:",
            "⚗️",
            ":alembic:",
            "🔍️",
            ":mag:",
            "🏷️",
            ":label:",
            "🌱",
            ":seedling:",
            "🚩",
            ":triangular_flag_on_post:",
            "🥅",
            ":goal_net:",
            "💫",
            ":dizzy:",
            "🗑️",
            ":wastebasket:",
            "🛂",
            ":passport_control:",
            "🩹",
            ":adhesive_bandage:",
            "🧐",
            ":monocle_face:",
            "⚰️",
            ":coffin:",
            "🧪",
            ":test_tube:",
            "👔",
            ":necktie:",
            "🩺",
            ":stethoscope:",
            "🧱",
            ":bricks:",
            "🧑‍💻",
            ":technologist:",
            "💸",
            ":money_with_wings:",
            "🧵",
            ":thread:"
          ]
        }
      }
    ]
  ]
}
@momocow
Copy link
Owner

momocow commented Jul 22, 2024

Sorry for late reply, here comes the explanation.

Those "default" emojis to be rendered in the final release notes are defined explicitly in the default template.

Therefore, the default template has nothing to do with the release rules in the current version.

But this behavior can/might be changed in the future version, since you are the second one to ask for the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants