Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Note release is being parsed as a uint16 instead of a byte #14

Open
Kaydax opened this issue Feb 9, 2021 · 0 comments
Open

Note release is being parsed as a uint16 instead of a byte #14

Kaydax opened this issue Feb 9, 2021 · 0 comments

Comments

@Kaydax
Copy link

Kaydax commented Feb 9, 2021

var release = reader.ReadUInt16();

In this line, release is being parsed as a uint16 instead of a byte, causing it to be incorrect. The byte after the note release is actually the note color channel inside of the pattern. I made a fix for this inside of my fork for .net standard but id rather not merge that with this to cause any other issues that may happen as I only tested this on 20.7+

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant