Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message was not encrypted for this device #240

Closed
Tracked by #322
bunnyfu opened this issue May 2, 2019 · 22 comments · Fixed by #506
Closed
Tracked by #322

Message was not encrypted for this device #240

bunnyfu opened this issue May 2, 2019 · 22 comments · Fixed by #506
Labels
🐟 OMEMO Related to OMEMO Encryption 🚫 Bug / Stability Releated directly to bugs or instability issues
Milestone

Comments

@bunnyfu
Copy link

bunnyfu commented May 2, 2019

Current testing scenario:
2 users, each logged into ejabberd server from macos (monal) and android (conversations). OMEMO enabled on all devices.

Correctly working when sending messages from conversations on android. Encrypted messages are received and correctly decrypted on android and macos.

Incorrectly working when sending messages from monal on macos. Encrypted messages are received and decrypted only on android. The receiving macos client displays error "Message was not encrypted for this device".

It would seems that monal is not using all omemo keys when encrypting the messages. Hopefully this can be fixed?

@Echolon
Copy link
Contributor

Echolon commented May 2, 2019

Evtl. related: MUC: Encryption & device publishing #225

@anurodhp
Copy link
Contributor

could you test on the current beta (3.7) and see if it persists?

@lgnap
Copy link

lgnap commented Jun 4, 2019

Hello, I had the same issue and so I'm seeking for the current beta.

Where can I find it? I searched the website, the brew install (same 2.4 - 135), and releases seems give source code only.

Thanks

@anurodhp
Copy link
Contributor

anurodhp commented Jun 4, 2019

The brew version is a little old but you can just get it from the download link on the side bar at monal.im

@lgnap
Copy link

lgnap commented Jun 4, 2019

This version is the 2.4. I tested it twice. We talk about the link Download Latest OS X Beta that provide monal.im/Monal-OSX/Monal-OSX.zip link ?

@tigexplorer
Copy link

tigexplorer commented Aug 8, 2019

Hi, same problem here!
I don't use iOS or MacOS for myself but was trying to install Monal on a iPhone and a iPad of friends of mine.

But get always this messages if trying to set encryption for the contact.
The contact uses several OMEMO Devices, Conversations, Gajim and Dino!
Monal version, installed from App-Store on Juli/Aug 19 seems to be: 3.8 (377)

@anurodhp
Copy link
Contributor

anurodhp commented Aug 8, 2019

I have observed this too. There is one case where i definitely see it on some servers if you are not subscribed to their other person's presence, then it can't get the OEMEO keys. That isn't an issue that i can solve. I am looking at resolving the key fetching though.

@tigexplorer
Copy link

I have observed this too. There is one case where i definitely see it on some servers if you are not subscribed to their other person's presence, then it can't get the OEMEO keys. That isn't an issue that i can solve. I am looking at resolving the key fetching though.

Can yo describe what the monal user or the other user (me) have to do?
For myself, I use mainly Conversations for years. I don't remember that I have to set a "presence" that other users OMEMO clients send me an encrypted message.

I don't have any Apple device, so it's hard to tell my friends what to do?

After opening this issue here, I have start a new here. IMHO it's better as separate issue:
https://github.com/anurodhp/Monal/issues/272

@a11fruitless
Copy link

Monal: 3.8.2 (iOS)

I can confirm this one as well. After recently reinstalling the app, I am now seeing the error posted above by tigexplorer. All users are subscribed to each other's presence. Neither my Gajim nor Converstaions client can see Monal's keys and vice versa.

I'm using an up-to-date Prosody 11.2 if that is any help here, and I can provide more detail about the server configuration if needed.

Funily enough, despite telling me that other client's dont support encryption, it also tells me it received encrypted messages from them it can't read. :)

@tigexplorer
Copy link

Please don't misunderstood this mention: After failing OMEMO Chat with Monal, I've installed ChatSecure on both partner devices (iPhone/ iPad) and was trying it with the same contacts and the same client on the other side (Conversations), and it works.
But the UI of Monal, I think, is cleaner, so I was trying it at first. I think, it hasn't to do with the xmpp server? I used for all testing accounts wiuwiu.de, that is IMHO a Prosody.

@Echolon Echolon added the 🐟 OMEMO Related to OMEMO Encryption label Jan 4, 2020
@Echolon Echolon mentioned this issue Jan 4, 2020
65 tasks
@Echolon Echolon added the 🚫 Bug / Stability Releated directly to bugs or instability issues label Jan 4, 2020
@Echolon
Copy link
Contributor

Echolon commented Feb 19, 2020

@bunnyfu @lgnap @tigexplorer

Hello guys, would you be so kind and test with the current version again and try to report the behavior?

@lgnap
Copy link

lgnap commented Feb 19, 2020

Another issue not linked after brew cask upgrade, maybe should open another ticket for it ?

Screenshot 2020-02-19 at 21 35 56

@licaon-kter
Copy link
Contributor

Can't be checked sounds like an Apple issue, not a Monal one.

They changed this in Catalina. That message is dumb, do a Right click - open or put on Desktop, hold CTRL then click.

@anurodhp https://developer.apple.com/documentation/xcode/notarizing_macos_software_before_distribution

@anurodhp
Copy link
Contributor

The catalyst builds are notarized. Will make them the version that is installed with brew

@tigexplorer
Copy link

tigexplorer commented Feb 20, 2020

I got this from a blind friend.
He cannot deal with it, nor can he read the error message, maybe it is not properly defined for voiceover.

@Echolon
Copy link
Contributor

Echolon commented Feb 20, 2020

@tigexplorer you both use Monal?

@anurodhp
Copy link
Contributor

ill test the text in voiceover. It should read just like any other message.

@tigexplorer
Copy link

@tigexplorer you both use Monal?

No, Conversations on the other side.

@Echolon
Copy link
Contributor

Echolon commented Feb 21, 2020

@tigexplorer I think Conversations is going to update again to send correct inital vectors as well I think.

@iNPUTmice am I correct?

@licaon-kter
Copy link
Contributor

@Echolon 2.7.0 already has that, if from Play store

For F-Droid there's no ETA, but next cycle will build it, hopefully.

@Echolon
Copy link
Contributor

Echolon commented Feb 21, 2020

Thank you, then just look out for the Conversations update please @tigexplorer

@Echolon Echolon closed this as completed Aug 19, 2020
@Echolon
Copy link
Contributor

Echolon commented Aug 19, 2020

Dear discussion participants,

I post this here because the next update is upcoming. We introduced many changes to the back-end and we want to ensure usability and quality. Therefore we call for testers of the also upcoming beta on Testflight. So, even we cannot guarantee this issue has been fixed yet we ask for your help!

We really appreciate your help and are looking forward to a better establishment of XMPP on iOS and Mac!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐟 OMEMO Related to OMEMO Encryption 🚫 Bug / Stability Releated directly to bugs or instability issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants