Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log warning when failing to find start or end #92

Closed
Archmonger opened this issue May 5, 2022 · 7 comments · Fixed by #93 or #177
Closed

Log warning when failing to find start or end #92

Archmonger opened this issue May 5, 2022 · 7 comments · Fixed by #93 or #177
Assignees
@mondeja
Labels
enhancement New feature or request

Comments

@Archmonger
Copy link

Archmonger commented May 5, 2022 •
edited by mondeja
Loading

Currently, if a start or end delimiter is not detected, the include tag silently handles this. This really ought to be logged via warning.
@mondeja mondeja added the enhancement New feature or request label May 5, 2022
@mondeja mondeja self-assigned this May 5, 2022
@mondeja mondeja mentioned this issue May 5, 2022
Merged
@mondeja
Copy link
Owner

mondeja commented May 5, 2022

Released in v3.4.0.

@Archmonger
Copy link
Author

Thank you!

@Archmonger
Copy link
Author

Looks like the latest version no longer warns on missing delimiters. Was this an intentional removal?

If not, sounds like a regression test might be needed.

@mondeja mondeja reopened this Aug 29, 2023
@mondeja mondeja changed the title Log warning when failing to find start or finish Log warning when failing to find start or end Aug 29, 2023
@mondeja mondeja mentioned this issue Aug 31, 2023
Merged
@mondeja
Copy link
Owner

mondeja commented Aug 31, 2023 •
edited
Loading

I'm pretty sure that #177 will fix the problem, but to be totally sure... could you give a try to the branch regression-92 @Archmonger?

You can install it with python3 -m pip install git+https://github.com/mondeja/mkdocs-include-markdown-plugin@regression-92

@Archmonger
Copy link
Author

Confirmed that branch fixes the regression.

@mondeja
Copy link
Owner

mondeja commented Aug 31, 2023

Released in v6.0.1.

@Archmonger
Copy link
Author

Archmonger commented Aug 31, 2023 •
edited
Loading

Thanks for the fix!

This really is an excellent plugin, definitely deserves more stars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mondeja mondeja

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@Archmonger @mondeja