-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new recursive
argument to include
directive
#208
Conversation
somewhere, probably, i should write that if this is done to avoid very-long-text substitutions, than the user should use If you think this can be handy only in this case scenario, i propose to make this directive only for |
4ccf454
to
90d6e61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, would you mind to add tests and documentation? If you think it's too complicated, don't worry, I'll do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This recursive
argument must be added to the include-markdown
directive as well.
ac2c42e
to
9ea518d
Compare
Do you see a scenario where markdown recursion might not be desirable, or is that just out of completeness? |
I don't think that it would add confusion, I don't understand where is the confusion here. Seems to me that it could be useful in certain scenarios, anyways not hurts to add it for completeness. |
This comment shows that it would add confusion, to me: #208 (comment) But yeah, i'm okay with adding the possibility for markdown too. If you think it's really better. I just wanted to warn you on this |
9ea518d
to
83f99fe
Compare
83f99fe
to
dbfcdf6
Compare
3fd0faf
to
409418b
Compare
recursive
directiverecursive
argument to include
directive
recursive
argument to include
directiverecursive
argument to include
directive
Fixes: #207
Additionally, it also excludes Jupyter Notebooks from the substitution, in case users are using
mkdocs-jupyter
to import files with very long text as cell outputs