From be616a65b84c9f910c19025eae7e1a6847cbdbfa Mon Sep 17 00:00:00 2001 From: Victoria Jeffrey Date: Mon, 17 Jun 2024 16:18:18 -0600 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=A7=B9=20ensure=20we=20always=20read?= =?UTF-8?q?=20the=20fine=20grained=20assets=20FF=20for=20AWS?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- providers/aws/resources/discovery.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/providers/aws/resources/discovery.go b/providers/aws/resources/discovery.go index 3707d7f838..30613caa26 100644 --- a/providers/aws/resources/discovery.go +++ b/providers/aws/resources/discovery.go @@ -222,11 +222,11 @@ func Discover(runtime *plugin.Runtime, filters connection.DiscoveryFilters) (*in } func handleTargets(targets []string) []string { + if ENABLE_FINE_GRAINED_ASSETS { + return append(AllAPIResources, DiscoveryAccounts) + } if len(targets) == 0 || stringx.Contains(targets, DiscoveryAuto) { // default to auto if none defined - if ENABLE_FINE_GRAINED_ASSETS { - return AllAPIResources - } return Auto } From 1a7f1c1f2b29d0e50df82cade6c5b039e8e1c1dd Mon Sep 17 00:00:00 2001 From: Victoria Jeffrey Date: Tue, 18 Jun 2024 13:07:32 -0600 Subject: [PATCH 2/2] =?UTF-8?q?=E2=9D=93=20why=20did=20the=20checksum=20fo?= =?UTF-8?q?r=20the=20azure=20query=20change=3F=20this=20is=20odd?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- mqlc/mqlc_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mqlc/mqlc_test.go b/mqlc/mqlc_test.go index 319484542b..75a4fb900a 100644 --- a/mqlc/mqlc_test.go +++ b/mqlc/mqlc_test.go @@ -298,7 +298,7 @@ func TestCompiler_DeterministicChecksum(t *testing.T) { azureConf := mqlc.NewConfig(azure_schema, features) res, err := mqlc.Compile(mql, map[string]*llx.Primitive{}, azureConf) require.Nil(t, err) - require.Equal(t, res.CodeV2.Id, "LkB8PP3xB2Q=") + require.Equal(t, res.CodeV2.Id, "h81H/YfoIRI=") } }