Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Replace unmaintained mapstructure #4851

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Nov 13, 2024

See 99designs/gqlgen#3343 for more details.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

Test Results

3 145 tests   3 144 ✅  1m 28s ⏱️
  371 suites      1 💤
   28 files        0 ❌

Results for commit 00f54f0.

♻️ This comment has been updated with latest results.

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czunker

@@ -64,7 +65,6 @@ require (
github.com/miekg/dns v1.1.62
github.com/mitchellh/go-homedir v1.1.0
github.com/mitchellh/hashstructure/v2 v2.0.2
github.com/mitchellh/mapstructure v1.5.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the config to prevent the addition going forward?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Done.

See 99designs/gqlgen#3343 for more details.

Signed-off-by: Christian Zunker <christian@mondoo.com>
@czunker czunker merged commit 42081a4 into main Nov 14, 2024
16 checks passed
@czunker czunker deleted the czunker/replace_mapstructure branch November 14, 2024 16:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants