-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardware wallet: request to plug in the device only when sending transaction #2952
Comments
Do you know if the view key gets saved locally? I don’t think this is the case. |
As I understand, the Monero GUI wallet file of a hardware wallet is a normal (spend) wallet that only holds the view key, and not the private key. Probably the view key is exported from the device when the wallet file is created. For the user experience, it seems to work like a normal (spend) wallet, because you send transactions normally using the usual fields of the send tab (the user doesn't have to use the offline transaction signing feature). However, in the background, it works like a view-only wallet that holds the private view key and does offline transaction signing in the device. Currently, if you create a view-only wallet of a Trezor wallet, the user will not be asked to plug in the device when opening this wallet. I'm not sure, but I guess the balance of this view-only wallet is not updated correctly now, because the hardware wallet firmware is not designed to send key images and outputs to a view-only wallet. |
In case of Ledger, the private view key is stored in RAM and not in the |
Hi @rating89us! The hardware wallet is required for opening the wallet due to the architecture design. Moreover, the key-image refresh is being done on the fly (HW wallet required). As a workaround, you can export the view key and create a pure software view-only wallet that does not require a connected hardware wallet to operate (however, your balance will be shown incorrectly and the key image sync would require some manual work). I think I am not going to refactor this as it could bring just more issues and I don't see a benefit in this overhaul (which is rather costly, I am doing this in my free time). But I can review pull requests. |
Yep, IMO does not sound worth it for the amount of work required. |
@dEBRUYNE-1 Do you know if it is possible to create a Ledger view-only wallet file (that holds the private view key permanently)? @ph4r05 And what do you think of redesigning this "manual work" that is required in the Trezor view-only wallet to keep the balance updated? So that when a user click a "refresh balance" button in the view-only wallet, it would be required to plug in the device, and then the view-only wallet would automatically manage the exporting of outputs and the importing of key images? |
@rating89us - my opinion on the redesigning is basically the same, not worth the effort for the amount of work needed. I don't have free time for such feature requests (as I am doing it as a hobby, opensource devel for free). I currently don't see an easy way to do it and I have to prioritize. But as I said, if somebody comes with the proposal and the PR I can consult and do the review. |
@rating89us - In theory that should be possible I guess. However, this feature does currently not exist. |
Currently it's not possible to open a wallet file from a hardware wallet without plugging in the device.
It would be better if it were possible to open the wallet as a view-only wallet, allowing the user to check the balance and incoming transactions.
This way the user would only be requested to plug in the device when a transaction is being sent or when a transaction key is being requested in transactions page.
The text was updated successfully, but these errors were encountered: