Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monero Multisig for HF #8237

Closed
UkoeHB opened this issue Apr 4, 2022 · 2 comments
Closed

Monero Multisig for HF #8237

UkoeHB opened this issue Apr 4, 2022 · 2 comments

Comments

@UkoeHB
Copy link
Contributor

UkoeHB commented Apr 4, 2022

There are currently several multisig PRs in the air. Ideally all of them would be merged before the upcoming hard fork.

Mandatory PRs

PR Author (Review) / Approved / Merged Status
Signature fixes #8149 merged
Post-kex verification round #8220 merged
Force-update option #8329 merged
Mitigate fund burning #8432 merged

Good-to-have PRs

PR Author (Review) / Approved / Merged Status
Kex round boosting #8203 @UkoeHB none Needs to rebase onto the force-update flag PR and get reviewed.
Code quality #7852 @UkoeHB @rbrunner7 Either review+merge or reject it.
@arnuschky
Copy link
Contributor

Thanks for the summary @UkoeHB - I was a bit lost after the dev meeting.

One question: You said above that the status of #8220 is "Needs a review of multisig kex changes." To what changes are you referring exactly? Are there additional, un-approved changes in the PR that you are referring to, or do you mean #8203?

@UkoeHB
Copy link
Contributor Author

UkoeHB commented Apr 4, 2022

@arnuschky #8220 adds a key exchange round, this is a change to the key exchange protocol that's in master. The reviews on that PR did not validate the kex changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@arnuschky @UkoeHB and others