monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir #7823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DangerOnTheRanger
force-pushed
the
wallet_dir_password_file_either_or
branch
2 times, most recently
from
4fcfa37
to
44b84c5
Compare
DangerOnTheRanger
force-pushed
the
wallet_dir_password_file_either_or
branch
from
b4d4975
to
61e31ad
Compare
selsta
reviewed
Aug 20, 2021
DangerOnTheRanger
force-pushed
the
wallet_dir_password_file_either_or
branch
from
61e31ad
to
5d4853a
Compare
|
Ok please squash and afterwards it should be good |
DangerOnTheRanger
force-pushed
the
wallet_dir_password_file_either_or
branch
from
5d4853a
to
24d3d65
Compare
selsta
approved these changes
Aug 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7624 by simply checking for the simultaneous presence of both
--password-fileand--wallet-dirwhen startingmonero-wallet-rpc.