RPC server: thread safety (+ small fix to on_getblockhash) #7937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-berman
changed the title
j-berman
changed the title
tobtoht
approved these changes
Mar 29, 2022
- grab an lmdb db_rtxn_guard to ensure consistent data from the db - fixed on_getblockhash error resp when requested height >= blockchain height - left functions that read shared memory untouched for now
j-berman
force-pushed
the
rpc-thread-safety-master
branch
from
d770100
to
83bb027
Compare
selsta
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7936